Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r101062900
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +719,23 @@ object SparkSubmit extends CommandLineUtils {
printWarning("Subclasses of scala.App may not work correctly. Use a
main() method instead.")
}
- val mainMethod = mainClass.getMethod("main", new
Array[String](0).getClass)
+ val sparkAppMainMethodArr = mainClass.getMethods().filter{_.getName()
== "sparkMain"}
+ val isSparkApp = sparkAppMainMethodArr.length > 0
+
+ val childSparkConf = sysProps.filter{ p =>
p._1.startsWith("spark.")}.toMap
+ // If running sparkApp or in thread mode, the System properties should
not be cluttered.
+ // This helps keep clean isolation between multiple Spark Apps
launched in different threads.
+ if (!isSparkApp || !threadEnabled) {
--- End diff --
actually shouldn't this just be !isSparkApp? because if it is the spark
app we are going to send sparkconf separate from the sys.env so we don't need
to send them both in childSparkConf and in the system properties.
If that is the case we don't need threadEnabled at all here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
