Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938028
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -89,11 +89,31 @@
private static volatile LauncherServer serverInstance;
/**
- * Creates a handle for an app to be launched. This method will start a
server if one hasn't been
+ * Creates a handle for an app to be launched using ChildProc.
+ * This method will start a server if one hasn't been
* started yet. The server is shared for multiple handles, and once all
handles are disposed of,
* the server is shut down.
*/
static synchronized ChildProcAppHandle newAppHandle() throws IOException
{
+ return (ChildProcAppHandle) LauncherServer.newAppHandle(false);
--- End diff --
It would be a little bit more code, but I think it's worth it to have
separate methods for child proc vs. child thread, to avoid ugly casts like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
