Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16871#discussion_r101171461
  
    --- Diff: project/SparkBuild.scala ---
    @@ -765,16 +750,6 @@ object CopyDependencies {
     
     }
     
    -object Java8TestSettings {
    -  import BuildCommons._
    -
    -  lazy val settings = Seq(
    -    javacJVMVersion := "1.8",
    -    // Targeting Java 8 bytecode is only supported in Scala 2.11.4 and 
higher:
    -    scalacJVMVersion := (if (System.getProperty("scala-2.10") == "true") 
"1.7" else "1.8")
    --- End diff --
    
    yeah, if it's working for you, that's good enough. I guess we'll find out 
pretty quickly if something needs to be adjusted in the jenkins jobs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to