Github user shaneknapp commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16871#discussion_r100860702
  
    --- Diff: project/SparkBuild.scala ---
    @@ -765,16 +750,6 @@ object CopyDependencies {
     
     }
     
    -object Java8TestSettings {
    -  import BuildCommons._
    -
    -  lazy val settings = Seq(
    -    javacJVMVersion := "1.8",
    -    // Targeting Java 8 bytecode is only supported in Scala 2.11.4 and 
higher:
    -    scalacJVMVersion := (if (System.getProperty("scala-2.10") == "true") 
"1.7" else "1.8")
    --- End diff --
    
    @srowen -- these builds grab the scala jar of the proper version depending 
on what axis is being built.  look in the dev/ directory at the code in there. 
    
    i'm also CCing @JoshRosen as the build scripts have come a long way since i 
last poked at them.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to