Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101219386
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,6 +32,18 @@ class CollapseRepartitionSuite extends PlanTest {
val testRelation = LocalRelation('a.int, 'b.int)
+
+ test("collapse two adjacent coalesces into one") {
+ val query = testRelation
+ .coalesce(10)
+ .coalesce(20)
--- End diff --
hmm, I can see the argument.
but there are 2 adjacent coalesces like this shouldn't it take the smaller
number? (since coalesce can't increase partition numbers)
whereas if there are 2 adjacent repartition it could take the last number
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
