Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16933#discussion_r101342124
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
 ---
    @@ -32,6 +32,18 @@ class CollapseRepartitionSuite extends PlanTest {
     
       val testRelation = LocalRelation('a.int, 'b.int)
     
    +
    +  test("collapse two adjacent coalesces into one") {
    +    val query = testRelation
    +      .coalesce(10)
    +      .coalesce(20)
    --- End diff --
    
    I think it would be better to respect the later input number, which is 
specified by users, for avoiding any surprise to users.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to