Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16964#discussion_r101834454
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java
---
@@ -255,21 +250,16 @@ public void testEncryptedMessageChunking() throws
Exception {
@Test
public void testFileRegionEncryption() throws Exception {
- final Map<String, String> testConf = ImmutableMap.of(
+ Map<String, String> testConf = ImmutableMap.of(
"spark.network.sasl.maxEncryptedBlockSize", "1k");
- final AtomicReference<ManagedBuffer> response = new
AtomicReference<>();
- final File file = File.createTempFile("sasltest", ".txt");
+ AtomicReference<ManagedBuffer> response = new AtomicReference<>();
+ File file = File.createTempFile("sasltest", ".txt");
SaslTestCtx ctx = null;
try {
- final TransportConf conf = new TransportConf("shuffle", new
MapConfigProvider(testConf));
+ TransportConf conf = new TransportConf("shuffle", new
MapConfigProvider(testConf));
StreamManager sm = mock(StreamManager.class);
- when(sm.getChunk(anyLong(), anyInt())).thenAnswer(new
Answer<ManagedBuffer>() {
- @Override
- public ManagedBuffer answer(InvocationOnMock invocation) {
- return new FileSegmentManagedBuffer(conf, file, 0,
file.length());
- }
- });
+ when(sm.getChunk(anyLong(), anyInt())).thenAnswer(invocation -> new
FileSegmentManagedBuffer(conf, file, 0, file.length()));
--- End diff --
This line is now too long (although we don't have automatic java style
checks.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
