Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16964#discussion_r101891096
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java
---
@@ -153,7 +148,7 @@ public void testEmptyFrame() throws Exception {
@Test(expected = IllegalArgumentException.class)
public void testLargeFrame() throws Exception {
// Frame length includes the frame size field, so need to add a few
more bytes.
- testInvalidFrame(Integer.MAX_VALUE + 9);
+ testInvalidFrame((long) Integer.MAX_VALUE + 9);
--- End diff --
It looks like this call isn't invalid per se at the moment. There is a
check later on in the code that compares a frame size to Integer.MAX_VALUE
(but, as a long, so it works) and throws an exception, but that doesn't occur
until later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
