Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16991#discussion_r102324213
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingQueryListenerBus.scala
 ---
    @@ -70,6 +70,10 @@ class StreamingQueryListenerBus(sparkListenerBus: 
LiveListenerBus)
             sparkListenerBus.post(s)
             // post to local listeners to trigger callbacks
             postToAll(s)
    +      case t: QueryTerminatedEvent =>
    +        // run all the listeners synchronized before removing the id from 
the list
    +        postToAll(t)
    --- End diff --
    
    It will post to all listeners directly in the current thread. Hence, the 
listener may see QueryProgressEvent after QueryTerminatedEvent.
    
    You can override `postToAll`. It's fine to remove `final` from the 
`postToAll` method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to