Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16991#discussion_r102547991
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingQueryListenerBus.scala
 ---
    @@ -75,6 +75,20 @@ class StreamingQueryListenerBus(sparkListenerBus: 
LiveListenerBus)
         }
       }
     
    +  /**
    +   * Post the event to all registered listeners. The `postToAll` caller 
should guarantee calling
    +   * `postToAll` in the same thread for all events. also remove the query 
id after all listeners
    +   * process the QueryTerminatedEvent
    --- End diff --
    
    Don't copy the comments from the parent class. You can just document it as:
    ```
    Override the parent `postToAll` to remove query from`activeQueryRunIds` 
after all listeners process `QueryTerminatedEvent`. (SPARK-19594)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to