Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16944#discussion_r102548681
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -690,10 +696,10 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
               "different from the schema when this table was created by Spark 
SQL" +
               s"(${schemaFromTableProps.simpleString}). We have to fall back 
to the table schema " +
               "from Hive metastore which is not case preserving.")
    -        hiveTable
    +        hiveTable.copy(schemaPreservesCase = false)
    --- End diff --
    
    In this case we are discarding the schema obtained from the table 
properties and explicitly falling back to using the case-insenstive schema 
obtained from the metastore. ```schemaPreservesCase``` needs to be set to 
```false``` here for the same reason it does at [line 
702](https://github.com/apache/spark/pull/16944/files/15c25e0fc23ec48ecd0fad7ca7c60d3a82d32a73#diff-159191585e10542f013cb3a714f26075R702).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to