Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16944#discussion_r102550641
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
    @@ -270,4 +271,9 @@ class SQLConfSuite extends QueryTest with 
SharedSQLContext {
         val e2 = 
intercept[AnalysisException](spark.conf.unset(SCHEMA_STRING_LENGTH_THRESHOLD.key))
         assert(e2.message.contains("Cannot modify the value of a static 
config"))
       }
    +
    +  test("Default value of HIVE_CASE_SENSITIVE_INFERENCE") {
    +    assert(spark.sessionState.conf.caseSensitiveInferenceMode ==
    +      HiveCaseSensitiveInferenceMode.INFER_AND_SAVE)
    --- End diff --
    
    IMO this test isn't really needed. You already have typo-safety via the 
enumeration check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to