Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16826#discussion_r102620806
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/TestSQLContext.scala ---
@@ -34,9 +40,32 @@ private[sql] class TestSparkSession(sc: SparkContext)
extends SparkSession(sc) {
this(new SparkConf)
}
- @transient
- override lazy val sessionState: SessionState = new SessionState(self) {
- override lazy val conf: SQLConf = {
+ class TestSessionState(
+ sparkContext: SparkContext,
+ sharedState: SharedState,
+ conf: SQLConf,
+ experimentalMethods: ExperimentalMethods,
+ functionRegistry: FunctionRegistry,
+ catalog: SessionCatalog,
+ sqlParser: ParserInterface,
+ analyzer: Analyzer,
+ streamingQueryManager: StreamingQueryManager,
+ queryExecution: LogicalPlan => QueryExecution)
+ extends SessionState(
+ sparkContext,
+ sharedState,
+ conf,
+ experimentalMethods,
+ functionRegistry,
+ catalog,
+ sqlParser,
+ analyzer,
+ streamingQueryManager,
+ queryExecution) {}
+
+ object TestSessionState {
+
+ def createTestConf: SQLConf = {
--- End diff --
is this needed any where else? then why make a separate method? just define
it inside `apply`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
