Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16826#discussion_r102622403
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
    @@ -212,3 +240,31 @@ private[sql] class HiveSessionCatalog(
         "histogram_numeric"
       )
     }
    +
    +private[sql] object HiveSessionCatalog {
    +
    +  def apply(
    --- End diff --
    
    Is this apply used anywhere other than in `clone`? if not, then there is no 
point creating an object with an `apply`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to