Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17059
That's compelling regarding performance. It's not big but not trivial.
My remaining concern is whether you're handling all the cases the original
did. `Number` covers a lot but does it include all the SQL decimal types? I
think the common casting mechanism would cover those. Granted, it's odd if
someone tries to use those values, but ideally would not work differently after
this change.
I am still not sure about the `Long` case -- don't you want to handle Scala
Long like Int here for efficiency?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
