Github user datumbox commented on the issue:
https://github.com/apache/spark/pull/17059
@srowen @mlnick I updated the PR based on what was discussed above and I
tested it again on Spark 2.1. I also updated the coding styles and the
exception message.
The changes requested by Sean, should not affect the speed of the proposed
solution but rather help us catch all the corner cases. I tested this by
generating a fresh batch of 1000 samples using the latest implementation
([details here](http://pastebin.com/vbbX1c7p)). The mean of the sample is
4.53837 which is no different than the mean of the code that I committed
yesterday (p-value 0.4265 - H0 of equal means can't be rejected). So we are
good.
Could any of the admins help re-test this because the "Jenkins, retest this
please" did not work for me earlier?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
