Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16959#discussion_r103348105
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -48,25 +48,29 @@ private[spark] class OutputCommitCoordinator(conf:
SparkConf, isDriver: Boolean)
private type StageId = Int
private type PartitionId = Int
private type TaskAttemptNumber = Int
+ private case class StageState(
+ authorizedCommitters: Array[TaskAttemptNumber],
+ failures: mutable.Map[PartitionId, mutable.Set[TaskAttemptNumber]])
--- End diff --
Why not define failures as an member variable (and initialize it there with
an empty map), rather than forcing the caller to pass in an empty map?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
