Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16959#discussion_r103354382
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -111,13 +115,13 @@ private[spark] class OutputCommitCoordinator(conf:
SparkConf, isDriver: Boolean)
val arr = new Array[TaskAttemptNumber](maxPartitionId + 1)
java.util.Arrays.fill(arr, NO_AUTHORIZED_COMMITTER)
synchronized {
- authorizedCommittersByStage(stage) = arr
+ stageStates(stage) = new StageState(arr)
--- End diff --
ah sorry now that I see this I realized it probably makes sense to
initialize `arr` in the StageState constructor too (so this line would look
like `new StageState(maxPartitionId +1)`, and the `StageState` constructor just
takes in `numPartitions`). Would you mind making that change too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
