Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17099#discussion_r103457544
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -452,14 +452,6 @@ object FoldablePropagation extends Rule[LogicalPlan] {
case u: UnaryNode if !stop && canPropagateFoldables(u) =>
u.transformExpressions(replaceFoldable)
- // Allow inner joins. We do not allow outer join, although its
output attributes are
- // derived from its children, they are actually different
attributes: the output of outer
- // join is not always picked from its children, but can also be
null.
- // TODO(cloud-fan): It seems more reasonable to use new attributes
as the output attributes
- // of outer join.
- case j @ Join(_, _, Inner, _) =>
--- End diff --
We forgot to check stop here. Can you just change this line into: `case j @
Join(_, _, Inner, _) if !stop =>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
