Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17099#discussion_r103501851
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/inner-join.sql ---
    @@ -0,0 +1,25 @@
    +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES (1) AS GROUPING(a);
    +CREATE TEMPORARY VIEW t2 AS SELECT * FROM VALUES (1) AS GROUPING(a);
    +CREATE TEMPORARY VIEW t3 AS SELECT * FROM VALUES (1), (1) AS GROUPING(a);
    +CREATE TEMPORARY VIEW t4 AS SELECT * FROM VALUES (1), (1) AS GROUPING(a);
    +
    +CREATE TEMPORARY VIEW ta AS
    +SELECT a, 'a' AS tag FROM t1
    +UNION ALL
    +SELECT a, 'b' AS tag FROM t2;
    +
    +CREATE TEMPORARY VIEW tb AS
    +SELECT a, 'a' AS tag FROM t3
    +UNION ALL
    +SELECT a, 'b' AS tag FROM t4;
    +
    +-- SPARK-19766 Constant alias columns in INNER JOIN should not be folded 
by FoldablePropagation rule
    +SELECT tb.* FROM ta INNER JOIN tb ON ta.a = tb.a AND ta.tag = tb.tag;
    +
    +-- Clean up
    +DROP VIEW IF EXISTS t1;
    --- End diff --
    
    i don't think you need these drop views, since TEMPORARY VIEW are destroyed 
immediately after this file.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to