Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15505#discussion_r103569761
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/local/LocalSchedulerBackend.scala
---
@@ -82,9 +88,15 @@ private[spark] class LocalEndpoint(
def reviveOffers() {
val offers = IndexedSeq(new WorkerOffer(localExecutorId,
localExecutorHostname, freeCores))
+ val abortTaskSet = new HashSet[TaskSetManager]()
for (task <- scheduler.resourceOffers(offers).flatten) {
- freeCores -= scheduler.CPUS_PER_TASK
- executor.launchTask(executorBackend, task)
+ val buffer = prepareSerializedTask(scheduler, task,
--- End diff --
Can you add a comment here about why we're serializing (and then
immediately deserializing) the task?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
