Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17076#discussion_r103778255
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -463,6 +458,8 @@ private class LinearSVCAggregator(
*/
def add(instance: Instance): this.type = {
instance match { case Instance(label, weight, features) =>
+ require(numFeatures == features.size, s"Dimensions mismatch when
adding new instance." +
+ s" Expecting $numFeatures but got ${features.size}.")
if (weight == 0.0) return this
--- End diff --
should the extra require be added:
require(weight >= 0.0, s"instance weight, $weight has to be >= 0.0")
similar to LogisticRegression.scala L1587 (in add method)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
