Github user yanboliang commented on the issue:

    https://github.com/apache/spark/pull/17076
  
    @sethah Thanks for the good catch. I verified this optimization and found 
it indeed reduced the size of shuffle data. This looks good to me. BTW, like 
@MLnick 's suggestion, could you add the lazy evaluation for gradient array to 
all other aggregators in this PR? Since it's little change, I'd prefer to 
modify it here. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to