Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17122
I would +1 for this. That is part of reason why I said it complicates the
logic in previous comment.
On Thu, Mar 2, 2017 at 9:40 PM, Herman van Hovell <[email protected]>
wrote:
> *@hvanhovell* commented on this pull request.
> ------------------------------
>
> In sql/core/src/main/scala/org/apache/spark/sql/execution/
> WholeStageCodegenExec.scala
> <https://github.com/apache/spark/pull/17122#discussion_r103925096>:
>
> > @@ -206,6 +206,18 @@ trait CodegenSupport extends SparkPlan {
> def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row:
ExprCode): String = {
> throw new UnsupportedOperationException
> }
> +
> + /**
> + * for optimization to suppress shouldStop() in a loop of
WholeStageCodegen
> + *
> + * isShouldStopRequired: require to insert shouldStop() into the loop
if true
> + */
> + def isShouldStopRequired: Boolean = {
> + shouldStopRequired || (this.parent != null &&
this.parent.isShouldStopRequired)
> + }
> +
> + // set true if doConsume() inserts append() method that requires
shouldStop() in the loop
> + protected var shouldStopRequired: Boolean = false
>
> We spend quite a bit of time debugging issues caused by poorly managed
> mutable vars in code generation. So I'd rather avoid it.
>
> â
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/17122#discussion_r103925096>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AAEM9zZCqOP-iZkRPr4hlkVp-aiXlML5ks5rhsbGgaJpZM4MPuc1>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
