Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r104078113
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +206,18 @@ trait CodegenSupport extends SparkPlan {
def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: ExprCode):
String = {
throw new UnsupportedOperationException
}
+
+ /**
--- End diff --
Suggestion for the comment:
/**
* For optimization to suppress `shouldStop()` in a loop of
WholeStageCodegen.
* Returning true means we need to insert `shouldStop()` into the loop
producing rows, if any.
*/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
