Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16867
I'm a little on the fence about this because of the added complexity, but
it does seem to be a significant time improvement. Did you consider
implementing this as a median heap (see the last post here:
http://stackoverflow.com/questions/15319561/how-to-implement-a-median-heap/15319593).
As long as this is solely to improve performance, it seems like we should do
the most efficient implementation, and the heap implementation is O(1) for all
operations (whereas this is logN to insert and I think similar to do the slice).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
