Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17117#discussion_r104094526
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/DefaultReadWriteTest.scala ---
@@ -111,12 +113,20 @@ trait DefaultReadWriteTest extends TempDirectory {
self: Suite =>
val estimator2 = testDefaultReadWrite(estimator)
testParams.foreach { case (p, v) =>
val param = estimator.getParam(p)
- assert(estimator.get(param).get === estimator2.get(param).get)
+ if (param.name == "initialModel") {
+ // Estimator's `initialModel` has same type as the model produced
by this estimator.
--- End diff --
This is an assumption, and is not enforced by the compiler. There is
nothing in the trait `HasInitialModel[T <: Model[T]]`that prevents us from
creating an estimator with an initialModel type that is not the same type of
the model that the estimator produces. We can discuss whether or not we'd like
to enforce this assumption, but if we do not then this method should probably
be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
