Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17117#discussion_r104095197
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
@@ -182,6 +224,7 @@ object KMeansSuite {
"predictionCol" -> "myPrediction",
"k" -> 3,
"maxIter" -> 2,
- "tol" -> 0.01
+ "tol" -> 0.01,
+ "initialModel" -> generateRandomKMeansModel(3, 3)
--- End diff --
It would be nicer to change `testEstimatorAndModelReadWrite` to accept
`estimatorTestParams` and `modelTestParams` separately so we don't have to hard
code certain params to be filtered out inside that method. Though we wouldn't
have to that in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
