Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/1940#issuecomment-55696539
This seems like it could be ok -- my only concern is about the semantics of
when we tell the user we've killed their job. Currently I think we invoke
a callback on JobWaiter saying that the job has been killed, iff the
schedulerBackend implements killTask. So, if we make killTask() best
effort, the semantics of that callback will change.
On Mon, Sep 15, 2014 at 10:06 PM, Patrick Wendell <[email protected]>
wrote:
> @kayousterhout <https://github.com/kayousterhout> thanks for the thorough
> analysis. Do you have any thoughts on just defining killTasks to be "best
> effort"? I think that would generally simplify the code a lot here.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/1940#issuecomment-55696321>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
