Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17100#discussion_r104455583
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
 ---
    @@ -398,16 +398,22 @@ class AnalysisErrorSuite extends AnalysisTest {
         // CheckAnalysis should throw AnalysisException when Aggregate 
contains missing attribute(s)
         // Since we manually construct the logical plan at here and Sum only 
accept
         // LongType, DoubleType, and DecimalType. We use LongType as the type 
of a.
    -    val plan =
    -      Aggregate(
    +    val attrA = AttributeReference("a", LongType)(exprId = ExprId(1))
    +    val aId = Array[String](attrA.name, attrA.exprId.id.toString)
    +    val otherA = AttributeReference("a", LongType)(exprId = ExprId(2))
    +    val otherAId = Array[String](otherA.name, otherA.exprId.id.toString)
    +    val plan = Aggregate(
             Nil,
    -        Alias(sum(AttributeReference("a", LongType)(exprId = ExprId(1))), 
"b")() :: Nil,
    -        LocalRelation(
    -          AttributeReference("a", LongType)(exprId = ExprId(2))))
    +        Alias(sum(attrA), "b")() :: Nil,
    +        LocalRelation(otherA))
     
         assert(plan.resolved)
     
    -    assertAnalysisError(plan, "resolved attribute(s) a#1L missing from 
a#2L" :: Nil)
    +    assertAnalysisError(plan,
    +                        "Some resolved attribute(s) are not present among 
available " +
    --- End diff --
    
    This is a weird mixing of strings formats.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to