Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17610954
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -167,14 +167,19 @@ class HistoryServer(
* This launches the HistoryServer as a Spark daemon.
*/
object HistoryServer extends Logging {
- private val conf = new SparkConf
val UI_PATH_PREFIX = "/history"
def main(argStrings: Array[String]) {
SignalLogger.register(log)
- initSecurity()
- new HistoryServerArguments(conf, argStrings)
+ val arg = new HistoryServerArguments(argStrings)
+ Option(arg.propertiesFile).foreach { file =>
--- End diff --
This block is repeated 3 times, maybe add it to Utils? Also, wonder if this
would look better:
Option(arg.propertiesFile)
.map { f => Utils.getPropertiesFromFile(f) }
.filter { case (k, v) => k.startsWith("spark.") }
.foreach { case (k, v) => sys.props.getOrElseUpdate(k, v) }
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
