Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17615063
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -360,14 +360,20 @@ private[spark] class Worker(
private[spark] object Worker extends Logging {
def main(argStrings: Array[String]) {
SignalLogger.register(log)
+ val args = new WorkerArguments(argStrings)
+ Option(args.propertiesFile).foreach { file =>
+ for ((k, v) <- Utils.getPropertiesFromFile(file) if
k.startsWith("spark.")) {
+ sys.props.getOrElseUpdate(k,v)
+ }
+ }
val conf = new SparkConf
- val args = new WorkerArguments(argStrings, conf)
- val (actorSystem, _) = startSystemAndActor(args.host, args.port,
args.webUiPort, args.cores,
- args.memory, args.masters, args.workDir)
--- End diff --
Hm looks like the import ordering is a little messed up now. Looks like
here we want to load properties before initializing `SparkConf`, so
`WorkerArguments` can no longer take in a conf. This logic seems a little
strange to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
