Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/17117#discussion_r104803180
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -37,9 +37,9 @@ import org.apache.spark.storage.StorageLevel
import org.apache.spark.util.VersionUtils.majorVersion
/**
- * Common params for KMeans and KMeansModel
+ * Common params for KMeans and KMeansModel.
*/
-private[clustering] trait KMeansParams extends Params with HasMaxIter with
HasFeaturesCol
+private[clustering] trait KMeansModelParams extends Params with HasMaxIter
with HasFeaturesCol
with HasSeed with HasPredictionCol with HasTol {
--- End diff --
Now, `KMeansModel` mixes `KMeansModelParams`, does it mean in the model
level, we can not get the information of the `initiModel`? Also, in the model,
why do we need to mix the seed in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
