Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17639971
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -244,18 +244,22 @@ case class Cast(child: Expression, dataType:
DataType) extends UnaryExpression {
b => x.numeric.asInstanceOf[Numeric[Any]].toFloat(b)
}
- private[this] lazy val cast: Any => Any = dataType match {
- case StringType => castToString
- case BinaryType => castToBinary
- case DecimalType => castToDecimal
- case TimestampType => castToTimestamp
- case BooleanType => castToBoolean
- case ByteType => castToByte
- case ShortType => castToShort
- case IntegerType => castToInt
- case FloatType => castToFloat
- case LongType => castToLong
- case DoubleType => castToDouble
+ private[this] lazy val cast: Any => Any = if (child.dataType ==
dataType) {
+ (e: Any) => e
+ } else {
+ dataType match {
+ case StringType => castToString
--- End diff --
Thank you @marmbrus , it's more clean. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
