Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17562464
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor[LogicalPlan] {
Batch("Combine Limits", FixedPoint(100),
CombineLimits) ::
Batch("ConstantFolding", FixedPoint(100),
+ SimplifyCasts,
--- End diff --
I'm not proposing that we don't use simplify casts. I'm proposing that it
should be possible to evaluate expressions even if we don't perform certain
optimizations. Any valid expression should be evaluate-able and there is
nothing invalid about casting a type to itself (just like there is nothing
invalid with an expression like `x + 0` even though the `+ 0` is a no-op).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
