[GitHub] spark pull request: [SPARK-2098] All Spark processes should suppor...

Wed, 17 Sep 2014 10:50:51 -0700 

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2379#discussion_r17680984
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
    @@ -47,14 +48,15 @@ private[spark] class WorkerArguments(args: 
Array[String], conf: SparkConf) {
       if (System.getenv("SPARK_WORKER_WEBUI_PORT") != null) {
         webUiPort = System.getenv("SPARK_WORKER_WEBUI_PORT").toInt
       }
    -  if (conf.contains("spark.worker.ui.port")) {
    -    webUiPort = conf.get("spark.worker.ui.port").toInt
    +  if (System.getenv("spark.worker.ui.port")!= null) {
    +    webUiPort = System.getenv("spark.worker.ui.port").toInt
    --- End diff --
    
    
對，这一点我明白。我的意思是说要是我们在`SparkConf`初始化以后调用`conf.setIfMissing`，我们就不需要在`SparkConf`初始化之前设置有å
…³çš„`sys.props`。这æ 
·çš„话我们就可以保持现有的初始化顺序。同时，因
为`spark-defaults.conf`也可以设置`spark.worker.ui.port`，我们要å…
ˆè¯»å–`spark-defaults.conf`才可以调用`conf.get("spark.worker.ui.port")`。这些逻辑å
…¨éƒ½å¯ä»¥åœ¨`WorkerArgument`以内
实现，那`Worker`就不需要怎么改。你懂我意思吗？


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to