Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2379#discussion_r17743007
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
 ---
    @@ -44,30 +51,27 @@ private[spark] class HistoryServerArguments(conf: 
SparkConf, args: Array[String]
         }
       }
     
    +  // Use common defaults file, if not specified by user
    +  propertiesFile = 
Option(propertiesFile).getOrElse(Utils.getDefaultConfigFile)
    --- End diff --
    
    I know I wrote this in the bug, but I'm wondering if this is really OK. 
Before, except for spark-submit, no daemons would read the default config file. 
So this has the potential to add config data that might make things behave 
differently when running the new Spark.
    
    Just a thought, though. I think the new behavior makes more sense, but it 
might trip some people.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to