Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17219#discussion_r106798566
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -419,14 +441,44 @@ class StreamExecution(
SQLConf.SHUFFLE_PARTITIONS.key,
shufflePartitionsToUse.toString)
}
- logDebug(s"Found possibly unprocessed offsets $availableOffsets " +
- s"at batch timestamp ${offsetSeqMetadata.batchTimestampMs}")
+ offsetLog.get(latestBatchId - 1).foreach { lastOffsets =>
+ committedOffsets = lastOffsets.toStreamProgress(sources)
--- End diff --
add a comment on what you are trying to do here. also if this is part of
the `// First assume that we are re-executing the latest batch in the offset
log` then might as well move this up there if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
