Github user tcondie commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17219#discussion_r107045633
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/Trigger.scala ---
    @@ -38,6 +38,51 @@ sealed trait Trigger
     
     /**
      * :: Experimental ::
    + * A trigger that runs a query once then terminates
    + *
    + * Scala Example:
    + * {{{
    + *   df.write.trigger(OneTime)
    + * }}}
    + *
    + * Java Example:
    + * {{{
    + *   df.write.trigger(OneTime.create())
    + * }}}
    + *
    + * @since 2.2.0
    + */
    +@Experimental
    +@InterfaceStability.Evolving
    +case class OneTime() extends Trigger
    +
    +/**
    + * :: Experimental ::
    + * Used to create [[OneTime]] triggers for [[StreamingQuery]]s.
    --- End diff --
    
    The explanation of OneTime trigger is given in the OneTime class 
definition. Does that suffice, or should the explanation be reiterated in the 
object definition?
    
    If it should be reiterated, then I can do the same with ProcessingTime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to