Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/17250#discussion_r107294828
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala
---
@@ -83,3 +84,146 @@ private[kinesis] final case class
STSCredentialsProvider(
}
}
}
+
[email protected]
+object SerializableCredentialsProvider {
--- End diff --
hmm. This isn't a great name for a user facing API, the user shouldn't have
to care about if the provider is serializable or not, that's an implementation
detail.
I understand your concerns with the `AWSCredentials` name collisions.
However, I think it's the best name there is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
