Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17250#discussion_r107318994
  
    --- Diff: 
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/SerializableCredentialsProvider.scala
 ---
    @@ -83,3 +84,146 @@ private[kinesis] final case class 
STSCredentialsProvider(
         }
       }
     }
    +
    +@InterfaceStability.Stable
    +object SerializableCredentialsProvider {
    +  /**
    +   * Builder for [[SerializableCredentialsProvider]] instances.
    +   *
    +   * @since 2.2.0
    +   */
    +  @InterfaceStability.Stable
    +  class Builder {
    +    private var awsAccessKeyId: Option[String] = None
    +    private var awsSecretKey: Option[String] = None
    +    private var stsRoleArn: Option[String] = None
    +    private var stsSessionName: Option[String] = None
    +    private var stsExternalId: Option[String] = None
    +
    +
    +    /**
    +     * Sets the AWS access key ID when using a basic AWS keypair for 
long-lived authorization
    +     * credentials. A value must also be provided for the AWS secret key.
    +     *
    +     * @param accessKeyId AWS access key ID
    +     * @return Reference to this 
[[SerializableCredentialsProvider.Builder]]
    +     */
    +    def awsAccessKeyId(accessKeyId: String): Builder = {
    --- End diff --
    
    I'll rework this builder to take multiple arguments for the long-lived 
keypair and STS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to