Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17295#discussion_r107789203
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -56,6 +57,44 @@ private[spark] class BlockResult(
         val bytes: Long)
     
     /**
    + * Abstracts away how blocks are stored and provides different ways to 
read the underlying block
    + * data. Callers should call [[dispose()]] when they're done with the 
block.
    + */
    +private[spark] trait BlockData {
    +
    +  def toInputStream(): InputStream
    +
    +  def toNetty(): Object
    +
    +  def toChunkedByteBuffer(allocator: Int => ByteBuffer): ChunkedByteBuffer
    +
    +  def toByteBuffer(): ByteBuffer
    --- End diff --
    
    I added scaladoc for `toNetty()`, but the others seem self-explanatory to 
me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to