Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17295#discussion_r107832519
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1065,7 +1084,7 @@ private[spark] class BlockManager(
try {
replicate(blockId, bytesToReplicate, level, remoteClassTag)
} finally {
- bytesToReplicate.unmap()
+ bytesToReplicate.dispose()
--- End diff --
I'm afraid this may counteract the effort we made in
https://github.com/apache/spark/pull/16499
Ideally `unmap` and `dispose` do different things
cc @mallman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
