GitHub user jsoltren opened a pull request:
https://github.com/apache/spark/pull/17402
[SPARK-7200] Add cleanup for memory leak tests to after() in TaskMemoâ¦
â¦ryManagerSuite
Cleans up all memory used by tests explicitly in after(). This new
function has the JUnit @After tag and thus is guaranteed to run, even
if an @Test method throws an exception.
Testing:
Ran tests locally.
Hacked an existing test and made sure that a failure was reported in
the original test, and not in after().
Verified test logging in
test-reports/org.apache.spark.memory.TaskMemoryManagerSuite.xml.
## What changes were proposed in this pull request?
Updates TaskMemoryManagerSuite based on Josh Rosen's comments in
SPARK-7200. It would be good to get some feedback as to whether or not this is
the right direction.
## How was this patch tested?
See "Testing" above.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoltren/spark jose-tungsten
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17402
----
commit c44fc87971c2b313df69ac2815bae1824e7ddb1b
Author: José Hiram Soltren <[email protected]>
Date: 2017-03-10T19:57:26Z
[SPARK-7200] Add cleanup for memory leak tests to after() in
TaskMemoryManagerSuite
Cleans up all memory used by tests explicitly in after(). This new
function has the JUnit @After tag and thus is guaranteed to run, even
if an @Test method throws an exception.
Testing:
Ran tests locally.
Hacked an existing test and made sure that a failure was reported in
the original test, and not in after().
Verified test logging in
test-reports/org.apache.spark.memory.TaskMemoryManagerSuite.xml.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
