Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r108491343
--- Diff:
core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
--- End diff --
Add `Assert.assertNotNull(manager)`.
Also, probably minor, but if a test fails, these checks will probably fail
in weird ways and might mask the original error... I'd try to insert a failure
in a test and seeing what happens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
