Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/14617#discussion_r107939502
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -74,8 +74,9 @@ class StorageStatusListener(conf: SparkConf) extends
SparkListener {
synchronized {
val blockManagerId = blockManagerAdded.blockManagerId
val executorId = blockManagerId.executorId
- val maxMem = blockManagerAdded.maxMem
- val storageStatus = new StorageStatus(blockManagerId, maxMem)
+ val maxOnHeapMem =
blockManagerAdded.maxOnHeapMem.getOrElse(blockManagerAdded.maxMem)
+ val maxOffHeapMem = blockManagerAdded.maxOffHeapMem.getOrElse(0L)
--- End diff --
the only time these fields will be `None` is when reading from old event
logs, right? If so, its worth adding that in as a comment above this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
