Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/14617#discussion_r107940464
--- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala
---
@@ -47,24 +50,30 @@ class StorageStatus(val blockManagerId: BlockManagerId,
val maxMem: Long) {
private val _nonRddBlocks = new mutable.HashMap[BlockId, BlockStatus]
/**
- * Storage information of the blocks that entails memory, disk, and
off-heap memory usage.
+ * Storage information of the blocks that entails on-heap memory,
off-heap memory and disk usage.
*
* As with the block maps, we store the storage information separately
for RDD blocks and
* non-RDD blocks for the same reason. In particular, RDD storage
information is stored
- * in a map indexed by the RDD ID to the following 4-tuple:
+ * in a map indexed by the RDD ID to the following 3-tuple case class:
*
* (memory size, disk size, storage level)
--- End diff --
this is out of date now that you have a separate case class. You could
just get rid of this comment describing it since the names on the case class
are pretty clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
