Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17379#discussion_r108577718
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala ---
@@ -32,15 +32,15 @@ import
org.apache.spark.sql.internal.{BaseSessionStateBuilder, SessionResourceLo
*/
private[hive] object HiveSessionState {
/**
- * Create a new Hive aware [[SessionState]]. for the given session.
+ * Create a new Hive aware [[SessionState]] for the given session.
*/
def apply(session: SparkSession): SessionState = {
new HiveSessionStateBuilder(session).build()
}
}
/**
- * Builder that produces a [[HiveSessionState]].
+ * Builder that produces a Hive aware [[SessionState]].
*/
@Experimental
@InterfaceStability.Unstable
--- End diff --
This file should not be named HiveSessionState anymore. It doesnt even have
the class HiveSessionState. It does have an object HiveSession, but do we need
that object any more?
@hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
