Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17379#discussion_r108662296
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
 ---
    @@ -134,6 +135,14 @@ abstract class BaseSessionStateBuilder(
       }
     
       /**
    +   * Interface exposed to the user for registering user-defined functions.
    +   *
    +   * Note 1: The user-defined functions must be deterministic.
    +   * Note 2: This depends on the `functionRegistry` field.
    +   */
    +  protected def udfRegistration: UDFRegistration = new 
UDFRegistration(functionRegistry)
    --- End diff --
    
    Minor: I was wondering why you moved this into the builder?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to