Github user johnc1231 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17459#discussion_r109320386
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/IndexedRowMatrixSuite.scala
---
@@ -89,11 +89,42 @@ class IndexedRowMatrixSuite extends SparkFunSuite with
MLlibTestSparkContext {
test("toBlockMatrix") {
val idxRowMat = new IndexedRowMatrix(indexedRows)
+
+ // Tests when n % colsPerBlock != 0
+ val blockMat = idxRowMat.toBlockMatrix(2, 2)
+ assert(blockMat.numRows() === m)
+ assert(blockMat.numCols() === n)
+ assert(blockMat.toBreeze() === idxRowMat.toBreeze())
+
+ // Tests when m % rowsPerBlock != 0
+ val blockMat2 = idxRowMat.toBlockMatrix(3, 1)
+ assert(blockMat2.numRows() === m)
+ assert(blockMat2.numCols() === n)
+ assert(blockMat2.toBreeze() === idxRowMat.toBreeze())
+
+ intercept[IllegalArgumentException] {
+ idxRowMat.toBlockMatrix(-1, 2)
+ }
+ intercept[IllegalArgumentException] {
+ idxRowMat.toBlockMatrix(2, 0)
+ }
+ }
+
+ test("toBlockMatrixDense") {
--- End diff --
I'm confused, you seem to have commented right on the toBlockMatrixDense
tests. Originally, toBlockMatrix had only the tests marked with the comment `//
Tests when n % colsPerBlock != 0`. I added the tests marked with `// Tests when
m % rowsPerBlock != 0` to toBlockMatrix, then used the same tests for the Dense
version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
